🌱 cleanup: build #3280
Merged
🌱 cleanup: build #3280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
perdasilva
force-pushed
the
cleanup/makefile
branch
3 times, most recently
from
1a9b6ba to
dab1ac1
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
perdasilva
force-pushed
the
cleanup/makefile
branch
from
dab1ac1 to
1c3d0cc
Compare
perdasilva
commented
May 27, 2024
| @@ -55,7 +55,6 @@ const ( | |||
|
|
|||
| olmConfigMap = "olm-operators" // No-longer used, how long do we keep this around? | |||
|
|
|||
| // sync name with scripts/install_local.sh | |||
There was a problem hiding this comment.
scripts/install_local.sh does not seem to reference anything to with the packageserver...
perdasilva
commented
May 27, 2024
|
|
||
| output: | ||
| format: tab | ||
| formats: tab |
There was a problem hiding this comment.
Changes in this file are to fix warnings given by the tool
added 5 commits
May 27, 2024 10:52
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
cleanup/makefile
branch
from
1c3d0cc to
84ccbd9
Compare
perdasilva
force-pushed
the
cleanup/makefile
branch
from
84ccbd9 to
147b0c6
Compare
m1kola
reviewed
May 27, 2024
Refactor Makefile clean up build targets Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
cleanup/makefile
branch
from
147b0c6 to
3b50b9f
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
cleanup/makefile
branch
from
3b50b9f to
7d54f0b
Compare
|
You will probably have to remove |
Merged
via the queue into
operator-framework:master
with commit May 27, 2024
c1b059a
12 checks passed
This was referenced Oct 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
imageGHA (we build the image for e2e anyway)Fast follows from this:
make lint(make sure the golangci-lint versions on dev and CI are the sameMotivation for the change:
Removing cruft from the project and trying to simplify things. Bumping k8s to 1.30 is causing some flakes. Having a tidy Makefile will make it easier to work with the codebase and fix issues.
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue